Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 카카오 로그인 구현 #25

Merged
merged 4 commits into from
Feb 3, 2024
Merged

feat: 카카오 로그인 구현 #25

merged 4 commits into from
Feb 3, 2024

Conversation

Puterism
Copy link
Member

@Puterism Puterism commented Feb 1, 2024

구현 목록

  • 카카오 로그인을 구현합니다.
    • 로그인 시 회원가입이 필요할 경우, 카카오 계정 정보로 회원가입 진행 후 회원가입 완료 페이지로 이동합니다.
  • 아이콘을 @boolti/icon 컴포넌트로 대체 적용합니다.

@Puterism Puterism self-assigned this Feb 1, 2024
Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for boolti-preview ready!

Name Link
🔨 Latest commit f4a257f
🔍 Latest deploy log https://app.netlify.com/sites/boolti-preview/deploys/65bdc626da4e9c0008615ada
😎 Deploy Preview https://deploy-preview-25--boolti-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for boolti-admin ready!

Name Link
🔨 Latest commit f4a257f
🔍 Latest deploy log https://app.netlify.com/sites/boolti-admin/deploys/65bdc6266e481300084405bc
😎 Deploy Preview https://deploy-preview-25--boolti-admin.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for boolti-super-admin ready!

Name Link
🔨 Latest commit f4a257f
🔍 Latest deploy log https://app.netlify.com/sites/boolti-super-admin/deploys/65bdc626e677d2000845b66b
😎 Deploy Preview https://deploy-preview-25--boolti-super-admin.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -54,6 +54,7 @@ tsconfig.tsbuildinfo

# env variables
.env
secrets.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오잉 .env를 사용안하는건가?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boolti/api에서 env를 사용하려면 추가로 설정이 필요해서 그냥 secrets.ts를 사용한건데... 근데 이거 netlify에서 빌드 에러나네.. env 설정으로 돌리긴 해야할 듯 ㅠㅠ

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타입 오류가 나서 그런가? 빌드할떄 들어 갈 것 같아서 vite 환경변수 쓰면 될 것 같은데!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e21de1c 에서 반영 완료

apps/admin/src/constants/localStorage.ts Show resolved Hide resolved

declare global {
interface Window {
Kakao: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

옵셔널로 넣는게 타입상 안전할수도! 그래선 안되겠지만 초기화가 실패한다던가..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확실히 안전하긴 하겠다!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f4a257f 에서 반영 완료

@alstn2468
Copy link
Member

고생했당!!

@Puterism Puterism merged commit f5e4788 into main Feb 3, 2024
13 checks passed
@Puterism Puterism deleted the feature/login branch February 3, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants