-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 카카오 로그인 구현 #25
feat: 카카오 로그인 구현 #25
Conversation
✅ Deploy Preview for boolti-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for boolti-admin ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for boolti-super-admin ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -54,6 +54,7 @@ tsconfig.tsbuildinfo | |||
|
|||
# env variables | |||
.env | |||
secrets.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오잉 .env를 사용안하는건가?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boolti/api에서 env를 사용하려면 추가로 설정이 필요해서 그냥 secrets.ts를 사용한건데... 근데 이거 netlify에서 빌드 에러나네.. env 설정으로 돌리긴 해야할 듯 ㅠㅠ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
타입 오류가 나서 그런가? 빌드할떄 들어 갈 것 같아서 vite 환경변수 쓰면 될 것 같은데!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e21de1c 에서 반영 완료
|
||
declare global { | ||
interface Window { | ||
Kakao: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
옵셔널로 넣는게 타입상 안전할수도! 그래선 안되겠지만 초기화가 실패한다던가..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확실히 안전하긴 하겠다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f4a257f 에서 반영 완료
고생했당!! |
구현 목록