feat: OCR 영수증 텍스트를 파싱한다 #16
Open
+160
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devxb
reviewed
Jan 29, 2025
| ) | ||
|
|
||
| if (parsedOcr.parsed.isEmpty()) { | ||
| throw ResponseStatusException(HttpStatus.BAD_REQUEST) |
There was a problem hiding this comment.
IllegalArgumentException을 던지고, ExceptionHandler에서 http status code를 정의하는건 어떨까요?
app layer에서 어떻게 통신했는지 (ex. 컨슈머인지, HTTP인지) 알 필요가 없다고 생각합니다.
| return parsedOcr | ||
| } catch (e: Exception) { | ||
| logger.error("Failed to parse ocr text.", e) | ||
| throw ResponseStatusException(HttpStatus.INTERNAL_SERVER_ERROR) |
There was a problem hiding this comment.
500 코드같은 경우는 IllegalStateException을 던지고 ExceptionHandler에서 잡을 수 있을것 같아요.
| .baseUrl(chatbotUrl) | ||
| .defaultHeaders { headers -> | ||
| headers.add(HttpHeaders.AUTHORIZATION, "Bearer $authorization") | ||
| headers.add(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON_VALUE) |
There was a problem hiding this comment.
ACCEPT를 명시하지않으면 기본으로 application/json으로 오나요??
| @@ -63,6 +73,27 @@ class CreateReviewFacade( | |||
| } | |||
| } | |||
|
|
|||
| fun parseOcrText(deviceId: String, ocrText: OcrTextRequest): ParsedOcrResponse { | |||
There was a problem hiding this comment.
parseOcrText 메소드는 CreateReviewFacade 객체보다 다른 객체에 있는게 자연스러울 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약
어떻게 구현했는지
다음 계획
이슈번호
close #15