Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repaired: name, symbol, volume, supply; numbers not as strings anymore #23

Merged
merged 9 commits into from
Feb 21, 2018
Merged

repaired: name, symbol, volume, supply; numbers not as strings anymore #23

merged 9 commits into from
Feb 21, 2018

Conversation

altsheets
Copy link
Contributor

@altsheets altsheets commented Oct 19, 2017 •
edited
Loading

explanations, see

please double and triple check my code though, not a JavaScript expert.

EDIT:

  • had been working fine (since my previous changes, October 2017)
  • added one more CMC layout change fix (February 2018)
  • comparing the output of CoinMarketCapAPI with the official cmc-API, myself I do prefer this CoinMarketCapAPI, so I am planning to keep this updated, at least for a while

Please merge with your master, thanks.

@altsheets
Copy link
Contributor Author

Please merge with your master, thanks.

@Nexuist Nexuist merged commit 55696ef into Nexuist:master Feb 21, 2018
@Nexuist
Copy link
Owner

Nexuist commented Feb 21, 2018

Sorry for the late reply - busy with life and such. Everything looks good, I appreciate all the hard work!

@altsheets
Copy link
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@altsheets @Nexuist