Added: Suppress that Annoying DBus Error on Some Wayland Compositors [for now] #2640
Conversation
| if (msg.Exception is AggregateException aggregateException | ||
| && aggregateException.InnerException is DBusException) | ||
| return false; |
There was a problem hiding this comment.
I don't think we should be excluding all D-Bus exceptions. D-Bus is used for selecting and opening files and links, among other things.
There was a problem hiding this comment.
Do you have a better suggestion? The situation kinda sucks and I'm open to anything.
We can't necessarily filter out by using the exception message; that may be localized; or contain localized parts.
The HRESULT is 0x80131500, which, as far as I can tell would likely be shared by other DBus Services.
The Stack Trace does not have any Avalonia code etc. we don't even know the caller of the issue. Nothing we could reference there either.
We have no hope of getting Avalonia to merge our changes, even if we were to fix it ourselves within the next 4-8 working days.
The situation... kinda sucks, a lot.
I don't think we can ship with users getting exception modals on every tooltip either though.
|
This PR conflicts with |
Just something I added on my own local machine last night, might aswell chuck it in here.
This suppresses the annoying DBus error that some Wayland compositors get while displaying tooltips in the UI.
Since we're releasing to a wider audience we can't really have constant error dialogs be thrown at end users; it's rough enough when testing, and probably much worse in actual use.
We need to report this upstream, if it's not reported already.
I left a note with the suppression in the source code.