Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brotli Support #713

Open
arlllk opened this issue Nov 11, 2020 · 4 comments
Open

Add Brotli Support #713

arlllk opened this issue Nov 11, 2020 · 4 comments

Comments

@arlllk
Copy link

arlllk commented Nov 11, 2020

Add the capability to use Brotli in the reverse proxy as a compression option. The official nginx module repository is currently active

@hitchhooker
Copy link

Has anybody come up with a fork or workaround to add brotli?

@jc21
Copy link
Member

jc21 commented Aug 13, 2021

Notes for anyone considering adding this:

  • The base docker image uses OpenResty and exists in this project and extensions are defined here. You'll need to open a PR there for this first
  • The UI should to have a switch to enable Compression and then select between gzip and brotli (if I understand this correctly)
  • This compression setting would need to be stored in the database and would require a new migration file
  • The proxy host nginx template exists here and would need to know about the compression choice.

@xrh0905
Copy link
Contributor

xrh0905 commented Jul 31, 2023

Member

Hi. I'm currently trying to work on it, but I'm new to these.
So,from what I can tell, Brotli support needs to be added upstream, which I opened a PR for that.
However, I'm not good at databases nor at frontend. And I guess it's safe to just leave brotli on as default.
It's should just work if you put brotli on; in the nginx.conf.

Please correct me if I'm wrong.
Sorry for any grammer mistakes or misspelling. My English is poor.

Copy link

Issue is now considered stale. If you want to keep it open, please comment 👍

@github-actions github-actions bot added the stale label Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants