feat(evm): Create ethers v6 adapters for Nibiru and publish TS library #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe pull request adds a new changelog entry for ethers v6 adapters for Nibiru and updates several build and configuration files. In the evm-core-ts project, new files such as a .gitignore, README, Justfile, package.json, and Prettier config have been introduced. Numerous TypeScript interfaces, typechain definitions, and autogenerated factory classes for Ethereum contracts are added or updated. Precompile contract files with HexAddr types, documentation enhancements, Solidity formatting improvements, ABI artifact updates, and a new file-skipping mechanism in the Go-based ABI generator are also included. Changes
Sequence Diagram(s)sequenceDiagram
participant FS as File System
participant GA as Gen-ABI Script
participant SK as SkipList Checker
FS->>GA: Traverse file (filename)
GA->>SK: Check if filename exists in skipList
alt File in skip list
SK-->>GA: Yes, skip file
GA->>FS: Continue to next file
else File not in skip list
SK-->>GA: No, process file
GA->>GA: Generate ABI from file
end
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (45)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Unique-Divine
changed the title
Unique-Divine
force-pushed
the
ud/simapp-from-app
branch
from
ead0ab8 to
bcacd0b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2197 +/- ##
=======================================
Coverage 64.78% 64.78%
=======================================
Files 277 277
Lines 22281 22281
=======================================
Hits 14435 14435
Misses 6861 6861
Partials 985 985 |
Unique-Divine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Abstract
This pull request implements the
@nibiruchain/evm-core package
Usage API
How I Tested This
I tested the usage of this package against a local network by creating a tarball and importing that locally to the package.json.
From
Nibiru/evm-core-ts, I runThis creates a "nibiruchain-evm-core*.tgz" file. Then in a separate JS project, I import the tgz file as a local dependency named
@nibiruchain/evm-core. This lets me get as close as possible to what an external will get when importing the package fromnpm, as installing a tarball dependency uses the compiled version of the package (only*.jsand*.d.tsfiles)