-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: app-db-backend not recognized on prune command #2217
Conversation
📝 WalkthroughWalkthroughThis pull request introduces three primary changes. A new entry has been added to the "Unreleased" section in the changelog documenting a bug fix for the app database backend during the prune command. The command registration in the CLI has been updated to use a new function signature that accepts an additional parameter, altering how the pruning command is initialized. Additionally, the dependency version for the Cosmos SDK in the go.mod file has been updated from version v0.47.11-nibiru.2 to v0.47.11-nibiru.3. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant R as RootCmd
participant P as Pruning Module
participant A as App Module
U->>R: Execute prune command
R->>P: Call Cmd(a.newApp, app.DefaultNodeHome)
P->>A: Initialize pruning with new parameters
A-->>P: Return application configuration
P-->>R: Signal command execution result
R-->>U: Deliver prune operation outcome
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (2)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
fb39a95
to
eac3bd1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2217 +/- ##
=======================================
Coverage 64.47% 64.47%
=======================================
Files 276 276
Lines 22390 22390
=======================================
Hits 14436 14436
Misses 6969 6969
Partials 985 985
|
No description provided.