Changed condition to attribute name. #3

NicBonetto · Oct 28, 2017 · ede38f3 · ede38f3
1 parent 9fc2b7f
commit ede38f3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/react-dom/src/__tests__/ReactDOMComponent-test.js b/packages/react-dom/src/__tests__/ReactDOMComponent-test.js
@@ -2287,8 +2287,8 @@ describe('ReactDOMComponent', () => {
       expectDev(console.error.calls.count()).toBe(1);
       expectDev(console.error.calls.argsFor(0)[0]).toContain(
         'Received `false` for non-boolean attribute `whatever`. If you mean to conditionally ' +
-          'pass an attribute, use a ternary expression: {condition ? `whatever` : undefined} ' +
-          'instead of {condition && `whatever`}.',
+          'pass an attribute, use a ternary expression: {`whatever` ? value : undefined} ' +
+          'instead of {`whatever` && value}.',
       );
     });
   });

diff --git a/packages/react-dom/src/shared/ReactDOMUnknownPropertyHook.js b/packages/react-dom/src/shared/ReactDOMUnknownPropertyHook.js
@@ -197,8 +197,8 @@ if (__DEV__) {
         warning(
           false,
           'Received `%s` for non-boolean attribute `%s`. If you mean to conditionally ' +
-            'pass an attribute, use a ternary expression: {condition ? `%s` : undefined} ' +
-            'instead of {condition && `%s`}.%s',
+            'pass an attribute, use a ternary expression: {`%s` ? value : undefined} ' +
+            'instead of {`%s` && value}.%s',
           value,
           name,
           name,