Convert date using js_util, remove print statements provide empty stream for notification not implemented on web yet #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eam for notification not implemented on web yet
martintrollip
commented
Jun 28, 2024
| @@ -208,19 +211,25 @@ class Mapper { | |||
| } | |||
|
|
|||
| static String? dateToString(dynamic date) { | |||
| if (date == null) return null; | |||
| final dateTime = DateTime.fromMicrosecondsSinceEpoch( | |||
| date.getTime() * 1000, | |||
There was a problem hiding this comment.
date.getTime() resulted in errors for compiled web apps.
martintrollip
commented
Jun 28, 2024
| @@ -21,7 +22,7 @@ class TwilioConversationsChannel extends EventEmitter { | |||
| external String? uniqueName; | |||
|
|
|||
| external dynamic getMessages(int? pageSize, int? anchor, String? direction); | |||
| external dynamic prepareMessage(); | |||
| external MessageBuilder prepareMessage(); | |||
There was a problem hiding this comment.
Defined this so that JS know which methods to call. In message_method the only change is to change dynamic to MessageBuilder and the rest of the interface remained the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helped with calling
date.getTimeon the dynamic date objectdart-lang/sdk#49399