Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert project from commonjs to esm modules #545

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

jgresham
Copy link
Member

@jgresham jgresham commented Apr 16, 2024

tldr; native node.js and browser support for using import instead of require

Some background on our build tools and switching to ESM (the new default for electron and vite moving forward)
electron/forge#3502
example repo https://github.com/jdms754/electron-forge-vite-esm-test

@jgresham jgresham changed the title testing conversion to esm modules but failing atm chore: convert project from commonjs to esm modules Apr 16, 2024
@jgresham jgresham merged commit 9e29a7f into chore/electron-forge-and-29 Apr 16, 2024
7 of 9 checks passed
@jgresham jgresham deleted the chore/esm-modules branch April 16, 2024 17:39
jgresham added a commit that referenced this pull request Apr 22, 2024
* wip convert to forge. missing env var in main

* fix svgs so both components and urls work for svgs

* replace electron-updater with electrons oob updater. package dep cleanup

* trying to make. cleanup imports using absolute paths.

* remove webpack references and cleanup package json build and packaging

* builds dmg and zip on mac. assets at top level needs to be renamed to public for vite

* more forge maker metadata. osx signing and notarizing

* replace prettier and eslint with biome js

* fix all unit tests but react test. replace jest with vitest

* fix github test and package actions

* try gha package env var for macOS code sign

* add windows to staging-publish

* add apple cert to signing

* add executableName to fix linux publishing

* use GITHUB_TOKEN instead of GH_TOKEN for publish default env var

* use npm ci for package. remove ignore in forge

* print statements to debug process.env.APPLE_PROD_CERT_NAME mac code signing

* remove mac from staging-publish

* fix notifications renderContent call

* fix check-disk-space. bimoe safe fix

* manually install python3 setup tools and appdmg for python 3.12 workaround

* setuptools first step. no cache npm

* copy all top level assets to build for now. can optimize later

* remove all eslint references

* fix windows build to be exe

* update deps electron-forge mainly

* e2e tests pass on mac. testing gha

* switch npm install to npm ci to avoid npm cache issues in ci

* debug statement to e2e gha and NO_CODE_SIGNING env var

* fix e2e binary path and arch on linux

* hardcode app binary path for e2e test

* Chore: storybook vite (#544)

* custom storybook vite path

* convert storybook nn theme to ts. remove unused deps

* remove nodeItegration true. unused

* chore: convert project from commonjs to esm modules  (#545)

* fix e2e test. convert tsconfig module to nodenext for esm

* chore: auto updater electron forge (#547)

* use autoUpdater from electron with github feedUrl for dialog control

* deb and rpm updater split with package manager selection

* chore: bump electron v 30

* chore: bump biome to 1.7.1

* chore: vite 5.2.10 and husky 9

* chore: bump react-i18next
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant