Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing engines limit #30

Closed
wants to merge 1 commit into from
Closed

Conversation

aversini
Copy link

Fixes #29

@NickColley
Copy link
Owner

I'm okay with this if we add testing for Node.js 6 (and 4 if possible)

Based on https://github.com/nodejs/Release

I'm worried otherwise I won't notice if this package starts failing in older versions of Node.js

@NickColley
Copy link
Owner

This can be done similar to https://github.com/pouchdb/pouchdb/blob/master/.travis.yml#L107, if you don't get time to do this, I can help out.

@aversini
Copy link
Author

Thanks ! I’ll try to find time. It’s not as simple as just updating the Travis config file right? I would also have to transpile the tests since they use async/await...

@NickColley
Copy link
Owner

I've updated the project to have a minimum of 6.x with #40, will release 3.x soon.

Thanks for raising this!

@NickColley NickColley closed this May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants