Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Core Web Vitals Diagnostic error #247

Closed
ifrountas opened this issue Feb 10, 2023 · 5 comments · Fixed by #262
Closed

Google Core Web Vitals Diagnostic error #247

ifrountas opened this issue Feb 10, 2023 · 5 comments · Fixed by #262

Comments

@ifrountas
Copy link

Hi there is a diagnostic error in core web vitals score.

Does not use passive listeners to improve scrolling performance and the hint is

Consider marking your touch and wheel event listeners as passive to improve your page's scroll performance. Learn more.

@anuj9196
Copy link

anuj9196 commented Jan 7, 2024

Hi, @ifrountas @kevinfarrugia Is there any update on this issue? I'm also getting the same warning in Google Lighthouse.

@NickPiscitelli
Copy link
Owner

It's easy enough to update the library to use passive listeners.

Let me research this more and I'll add if there is no drawback.

@sms20
Copy link

sms20 commented Mar 12, 2024

Hi, this is also getting flagged for us in PageSpeed Insights (https://pagespeed.web.dev/).

I noticed this working branch: https://github.com/NickPiscitelli/Glider.js/tree/passive-listeners.. In my limited testing this branch does seem to fix the issue.

Please can you provide an update.

Thanks.

@oconnorjoseph
Copy link

Hello @NickPiscitelli, also getting this flagged. That same branch looks to work for us as well. Any development would be heavily appreciated.

@NickPiscitelli
Copy link
Owner

NickPiscitelli commented Apr 28, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants