-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Core Web Vitals Diagnostic error #247
Comments
Hi, @ifrountas @kevinfarrugia Is there any update on this issue? I'm also getting the same warning in Google Lighthouse. |
It's easy enough to update the library to use passive listeners. Let me research this more and I'll add if there is no drawback. |
Hi, this is also getting flagged for us in PageSpeed Insights (https://pagespeed.web.dev/). I noticed this working branch: https://github.com/NickPiscitelli/Glider.js/tree/passive-listeners.. In my limited testing this branch does seem to fix the issue. Please can you provide an update. Thanks. |
Hello @NickPiscitelli, also getting this flagged. That same branch looks to work for us as well. Any development would be heavily appreciated. |
This is now available as an option in 1.7.9 called `passiveListeners`; let
me know if this works for you.
I will look into making this the default but I have hesitations around
suppressing the scrolling for horizontal wheels and need to look further
into it.
…On Thu, Apr 25, 2024 at 9:14 PM oconnorjoseph ***@***.***> wrote:
Hello @NickPiscitelli <https://github.com/NickPiscitelli>, also getting
this flagged. That same branch looks to work for us as well. Any
development would be heavily appreciated.
—
Reply to this email directly, view it on GitHub
<#247 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM33FJHDOPQDVKFWI3CAH3Y7GS5XAVCNFSM6AAAAAAUXY6CJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZYGQ2TIOJYHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi there is a diagnostic error in core web vitals score.
Does not use passive listeners to improve scrolling performance and the hint is
Consider marking your touch and wheel event listeners as
passive
to improve your page's scroll performance. Learn more.The text was updated successfully, but these errors were encountered: