Fix for issue 144 #146
Merged
Fix for issue 144 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a slide index data attribute to each slide upon initialisation.
line 103,
[].forEach.call(_.slides, function (_) {
_.classList.add('glider-slide')
})
changed to
[].forEach.call(_.slides, function (_,i) {
_.classList.add('glider-slide');
_.setAttribute('data-gslide',i)
})
slide index attribute
|
Hi aurovrata, Thanks for the fix; this makes sense to me. |
|
Sooper! Happy to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144
Here is a proposal for fixing the scrollLeft reset by creating a
_.scrollLefton the Glider object and using that instead of the_.ele.scrollLeft