Merge branch 'flask_hooks' of https://github.com/nicksulistio/opentel…

…emetry-python-contrib into flask_hooks
NickSulistio · Jun 1, 2021 · ddc10d7 · ddc10d7
2 parents b867ead + e941831
commit ddc10d7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/...n/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py b/...n/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py
@@ -115,8 +115,8 @@ def _start_response(status, response_headers, *args, **kwargs):
                         "missing at _start_response(%s)",
                         status,
                     )
-                if response_hook:
-                    response_hook(span, status, response_headers)
+                if response_hook is not None:
+                    response_hook(span, status, response_headers)         
             return start_response(status, response_headers, *args, **kwargs)
 
         return wsgi_app(wrapped_app_environ, _start_response)

diff --git a/instrumentation/opentelemetry-instrumentation-flask/tests/test_programmatic.py b/instrumentation/opentelemetry-instrumentation-flask/tests/test_programmatic.py
@@ -285,7 +285,6 @@ def request_hook_test(span, environ):
 
         def response_hook_test(span, environ, response_headers):
             span.set_attribute("hook_attr", "hello world without app")
-            # environ.headers.set("apple", "cat")
             response_headers.append(hook_headers)
 
         FlaskInstrumentor().instrument(