Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX][FE] Fixup CnvToPDF issue while submit process #107

Merged
merged 3 commits into from
Apr 8, 2024
Merged

[HOTFIX][FE] Fixup CnvToPDF issue while submit process #107

merged 3 commits into from
Apr 8, 2024

Conversation

Nicklas373
Copy link
Owner

  • Fix issue with undetermined array pool variable for uploaded file, which is should pool for name response, not fileName. Due this condition, FE side send "Unknown" file to the BE and causing error everytime response was send.

NOTE:

  • BE crashes when get this response [500 Internal server error]
  • FE can catch it correctly this error and return feedback error modal or dialog without any crashes

@Nicklas373
KAO-Logic: Minor fixes
48213e2 
* Fixup wrong file array declaration that prevent user to proceed, due unknown
file name that was stored on array pool

Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
@Nicklas373
vite: Update static library
526dae6 
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
@Nicklas373
Composer: Update dependencies
97ff8ec 
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
@Nicklas373 Nicklas373 added the bug Something isn't working label Apr 8, 2024
@Nicklas373 Nicklas373 self-assigned this Apr 8, 2024
@Nicklas373 Nicklas373 changed the title [HOTFIX]: Fixup CnvToPDF issue while submit process [HOTFIX][FE] Fixup CnvToPDF issue while submit process Apr 8, 2024
@Nicklas373 Nicklas373 added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 8, 2024
@Nicklas373 Nicklas373 merged commit 57c13c2 into fe/master Apr 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Nicklas373 Nicklas373

Labels
bug Something isn't working dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nicklas373