HANA PDF v2.3 #12
Merged
HANA PDF v2.3 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not set to sticky layout, position fixed at the bottom from the layout Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Orientation 45 → 0 Degrees Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Title Error Message (allModal) : “Please choose PDF file !” → “Please choose PDF file!” “Unsupported file format !” → “Unsupported file format!” Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Title Headline - Need bigger font size Sub Title Headline - Need smaller font size Menu Title - Need smaller font size Feature List [With title feature card, all pages] : - Title feature text need bigger font size [Only on mobile] - Title feature text re-position more down [Only on mobile] [Reference from desktop design] - Title sub feature text following more down position from title feature [Only on mobile] [Reference from desktop design] [Compress & Convert Page] - Title feature text need bigger font size [Only on mobile] - Title feature text re-position more down [Only on mobile] [Reference from desktop design] - Title sub feature text following more down position from title feature [Only on mobile] [Reference from desktop design] Convert Page: 1. Convert To PDF - Title Page * “PDF Convert” → “Convert to PDF” 2. Convert From PDF - Title Page * “PDF Convert” → “Convert From PDF” 3. HTML To PDF - Title Page * “HTML To PDF” → “HTML to PDF” Reference: - Sanity testing [UX] at 18 November 2023 Related Change: - resources/views/includes/header.blade.php - resources/views/layouts/default.blade.php - resources/views/pages/cnvFromPDF.blade.php - resources/views/pages/cnvMain.blade.php - resources/views/pages/cnvToPDF.blade.php - resources/views/pages/compress.blade.php - resources/views/pages/htmltopdf.blade.php - resources/views/pages/merge.blade.php - resources/views/pages/split.blade.php - resources/views/pages/watermark.blade.php - resources/views/pages/welcome.blade.php Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
- Function sub title [selected pages] change color to softest → Reference from Watermark PDF page - Error message “First page can not more than last page” → “First page can’t be more than last page” Reference: - Sanity testing [UX] at 18 November 2023 Related Change: - public/ext-js/kao-main.js - resources/js/kao-logic.js Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
All radio button need to re-mapping with this condition: Element that wrapping radio button with text should can be clicked and trigger radio to selected, with hover interactively change after it Everytime hover move to some of radio button or element that wrap it up, that element with radio button should run the hover function alternatively kao-main should be re-written [RE-FACTORING] to make it simple and keep optimize from this changes Related changes: - All layout with radio button - kao-main.js
* BE-001: Filename formatting Slightly change filename naming scheme or format to make it simple and easier to recognize suffix template: - pdf_compress_8code.pdf [format: feature-title_8code.ext] khusus split: - pdf_split_8code_page-n [format: feature-title_8code_page-n.ext] * BE-002: More database record implementation Implement more database insert to record all failed process; [ Some of process still are not record to database, when error are not came from API process or main process ] Within this condition, the process id can be still generated if the process error. But it can’t be traced on DB, because it wasn’t inserted in any chance. Add more insert logic to DB on this condition, will make logging more advanced and easier to trace [Should be applicable on all controllers] * BE-003: Add logic to prevent laravel crash whenever database eloquent error In some case, laravel app got some crash when database eloquent process fail. Due unprotected run process, database eloquent may stop the laravel and return error 500 [Internal Server Error]. Resolution: - Create try catch logic to prevent laravel app crash, whenever eloquent logic fail. And return error message to user with exact error or simple unified message error * BE-004: Properly encrypt file to iLovePDF API All file that was send by using iLovePDF API are not encrypted by default, and could possibiity with security leaks issue, iLovePDF API itself already use JWT token with full SSL encryption. But better to protect more Possibility Issue: - Security leaks - Data breach while POST to iLovePDF API - Task can be tracked if task id can be trace, due task are not automatically removed after process [2 Hours after task started, it will automatically deleted] Resolution: - Include some iLovePDF API flags to enable encryption - Include some iLovePDF API flags to auto delete task after download process complete - Need to apply to all controllers that access iLovePDF API POST - Need to create dynamic encryption key that always change whenever task start
…F page Background: In some scenario user may input last page for split more than total pdf page, that case aren’t stopper and not make any error from the apps. But it can be complain from user due different number page that already inserted before, ilovepdf logic will auto limit last page whenever user input page more than total pdf page. Possibility Issue: - PDF still processed, but selected page if more than total pdf pages aren’t processed Resolution: - Get total PDF page from uploaded file, then throw back to split page as separate response variable. So it can be user from kao-logic to prevent user input variable more than that. Related Changes: - resources\js\kao-logic.js - resources\views\pages\split.blade.php
Switch extract pages feature to remove pages on split PDF pages Split PDF - Delete page (Remove pages → switch from extract pages) References: - https://developer.ilovepdf.com/docs/guides/split-pdf-api
Implement feature Extract image from PDF references: - https://github.com/ilovepdf/ilovepdf-php/blob/master/samples/pdfjpg_advanced.php
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Nicklas373
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.3 20231207 [HANA PDF]