Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX][BE] Fix total pages for PDF are not counted on FE services #151

Merged
merged 6 commits into from
Jun 2, 2024
Merged

[HOTFIX][BE] Fix total pages for PDF are not counted on FE services #151

merged 6 commits into from
Jun 2, 2024

Conversation

Nicklas373
Copy link
Owner

Nicklas373 added 6 commits June 2, 2024 23:27
@Nicklas373
Console: Properly tell instances that run scheduler
c359954 
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
@Nicklas373
Controllers: htmltopdf: Drop Auto
29495bd 
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
@Nicklas373
Controllers: Split: Add guard logic for totalpdfpages
576ef91 
* Add new logic to avoid crash when totalpdfpages are return in unconditional response

Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
@Nicklas373
Notify: Include logresult to find data
86c5a4f 
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
@Nicklas373
Upload: Add new function to count total pdf pages
bd66231 
Since FE are relying to ready this upload / public storage path on BE instances, after
switch to API only route. It seems upload / public storage folder are not accessible from FE
services, due that path are not registered in any route on BE services. Instead directly access to
BE storage folder, create new route and function to count and return exact total PDF pages to FE
services.

Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
@Nicklas373
Version: Bump to v3.2.7
c0ef7f7 
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
@Nicklas373 Nicklas373 added bug Something isn't working enhancement New feature or request dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Jun 2, 2024
@Nicklas373 Nicklas373 self-assigned this Jun 2, 2024
@Nicklas373 Nicklas373 merged commit 769df04 into be/master Jun 2, 2024
2 checks passed
@Nicklas373 Nicklas373 deleted the dev/be/master branch June 2, 2024 16:47
@Nicklas373 Nicklas373 restored the dev/be/master branch June 2, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Nicklas373 Nicklas373

Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nicklas373