v3.3.1 20240818 [Backend Module] #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
In some condition when custom page ranges was inputted, value sometimes are not really custom. It can be integer without any string on it, in that case hana-pdf can threw overflow integer into iLovePDF API. Although it should be return error from iLovePDF, but it should be good if it can be handle from backend instead. Apply more guard logic to protect if value was input on custom page are integer, then do logic to check if page number are not more that total pdf pages. And also properly include some database insert on some error, it should be tracked too. Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Nicklas373
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent Changelog:
Controllers: Split: Try to handle un-count custom pages
Description:
In some condition when custom page ranges was inputted, value sometimes are not
really custom. It can be integer without any string on it, in that case hana-pdf
can threw overflow integer into iLovePDF API.
Although it should be return error from iLovePDF, but it should be good if it can be
handle from backend instead. Apply more guard logic to protect if value was input on
custom page are integer, then do logic to check if page number are not more that total
pdf pages.
And also properly include some database insert on some error, it should be tracked too.