[BE][HOTFIX]: Fix may-nullable validation params #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make sure all required may-nullable variable was served from the request to prevent missing variable - Properly check validation for free text params with only allowed charactes is string 'all', number and hyphens symbol. Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Nicklas373
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In last update, i was update some validation logic to 'required' from 'nullable' in split and watermark controllers. But some of that value was never served from the frontend with default value when empty. And it make validation logic hit and return error validation.
Solution
Update core API to properly declare and handle may-nullable variable, instead only declare as required
Commit
Handling for previous pull request
#232