v3.4.4 20250112 [Frontend Module] #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make sure file that was uploaded was not contain non-standard characters or duplicate characters on it Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Signed-off-by: Dicky Herlambang (花） <herlambangdicky5@gmail.com>
Nicklas373
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
As users, i want to upload any file that i want to proceed without any worries regarding non-standarize name on file or not
Current condition
iLovePDF seems have sensitive case regarding non-standarize or duplicate characters on file name that want to proceed, so whenever any file that have non-standarize or duplicate characters on it. It will return error and crash iLovePDF logics with error
({"error":{"type":"ServerError","message":"Something on our end went wrong, probably we are not catching some exception we should catch! We are logging this and we will fix it.","code":"500"}})Next condition
Handle properly on the front-end services to rename any uploaded file before serve to the backend, this is better approach and less modification on source code. Due change renaming logic on backend could be hectic and risky.