Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in Symbol Tables #2

Merged
merged 42 commits into from
Aug 28, 2022
Merged

Added in Symbol Tables #2

merged 42 commits into from
Aug 28, 2022

Conversation

NickyBoy89
Copy link
Owner

This PR merges in the functionality to use symbol tables by default. This means things such as

  • Overloaded Methods are renamed correctly
  • Declarations with visibility controls (public, private, etc...) are all renamed correctly
  • Reserved keywords are handled correctly (map, string) are both valid variable names in Java, but illegal in Go

Any many more things are handled more correctly this time, bringing the translation closer to a 1-to-1 conversion

This will however, make some parts of the parser more fragile, so there has been a flag added to disable this functionality, which is in-progress

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
…private renaming methods

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
…or it

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
…nality of the file

Verified

This commit was signed with the committer’s verified signature. The key has expired.
MylesBorins Myles Borins
…tedly

This changes it so every file will only be read from disk once, instead
of being read three different times

This comes at a memory tradeoff, but the total cost of each source file
is extremely small, even for a large project, that this is a large
speedup

Verified

This commit was signed with the committer’s verified signature. The key has expired.
MylesBorins Myles Borins
…pe definition names

Search now works off of the original types of the method

Unverified

The email in this signature doesn’t match the committer email.
…o reflect that
@NickyBoy89 NickyBoy89 merged commit 2b09b8b into master Aug 28, 2022
@NickyBoy89 NickyBoy89 deleted the symbol-tables branch August 28, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant