Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] files are not stored #6

Closed
Nowalon opened this issue Oct 22, 2014 · 10 comments
Closed

[windows] files are not stored #6

Nowalon opened this issue Oct 22, 2014 · 10 comments

Comments

@Nowalon
Copy link

Nowalon commented Oct 22, 2014

Hi!
I have no any stored file in c:\Users\MyUserName.atom\local-history\ on Windows (7 x64).
And empty list ("No mathes found") of revisions.

What i should to do to make it powerful on Windows?

Thank you!

@Nicolab
Copy link
Owner

Nicolab commented Oct 22, 2014

Hello,

I never tested on Windows.

You have an error in the console of Atom ? (Developer tools: Ctrl + Shift + I)

@Nicolab Nicolab changed the title no any stored files [windows] files are not stored Oct 22, 2014
@Nicolab Nicolab added the bug label Oct 22, 2014
@Nowalon
Copy link
Author

Nowalon commented Oct 23, 2014

Hi! Thank you for anwer!
no errors in console now.
I had some errors yesterday, I can not remember, something about "error creating node". After restart Atom it's gone (but history still doesnt work).
it Maybe some differences in file system (etc.) permissions. I had no time to check it on Ubuntu at home yesterday.

@Nicolab
Copy link
Owner

Nicolab commented Oct 23, 2014

Ok.
On Ubuntu it works fine (I have Ubuntu).
I'll try on windows.

@skandasoft
Copy link

same here..any updates..

@Nicolab
Copy link
Owner

Nicolab commented Nov 23, 2014

I tested on Windows but no error message. Probably a stupid bug like the path or the permission but without any indication, I can not fix.

If a Windows user can tell me where is the problem with Windows, then I will fix.

@jp187
Copy link
Contributor

jp187 commented Nov 26, 2014

Nicolas,
It is the drive letter in the path.
In local-history-view.js and utils.js

added logic to drop the ":" in the path and I can confirm that it is saving history, showing the history list and starting meld as intended.

I can share the code changes if you wish.

@Nicolab
Copy link
Owner

Nicolab commented Nov 27, 2014

@jp187

Great !

I can share the code changes if you wish.

Yes please :)
Thank you

@jp187
Copy link
Contributor

jp187 commented Nov 27, 2014

Nicolas,

How do you want the code changes? I can push a branch or send via email.

-j.p.

Nicolas Talle mailto:notifications@github.com
Wednesday, November 26, 2014 8:35 PM

@jp187 https://github.com/jp187

Great !

Yes please :)
Thank you


Reply to this email directly or view it on GitHub
#6 (comment).

-j.p.


This email is free from viruses and malware because avast! Antivirus protection is active.
http://www.avast.com

@Nicolab
Copy link
Owner

Nicolab commented Nov 27, 2014

As you like.

  • Fork and send a pull request with your changes (it's the best for you appear in the contributors)
  • or post the code here
  • or email

If you send a PR, I suggest a commit message like "Fix Windows storage (#6)"

Thanks!

jp187 added a commit to jp187/atom-local-history that referenced this issue Nov 27, 2014
Nicolab added a commit that referenced this issue Dec 1, 2014
@Nicolab
Copy link
Owner

Nicolab commented Dec 1, 2014

Fixed by #7 and released to v1.1.0.

Thanks @jp187

@Nicolab Nicolab closed this as completed Dec 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants