Add Bitcoin Core 23.0 and 24.0.1 #37
Conversation
|
Bitcoin 24.0 was not announced and should not be released as a docker image. https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-24.0.md |
|
Sorry, you are totally right. I overlooked this on my side. Will change it to 24.0.1. |
Signed-off-by: Johannes Zweng <johannes@zweng.at>
johnzweng
force-pushed
the
add-bitcoin-core-v23-and-v24
branch
from
6bc14fa to
453791e
Compare
|
Done. ✅ I changed 24.0 to 24.0.1 reverified signatures from SHA256SUMS.asc (but you should not trust me and do the same yourself), built it on my machine and ran it. Seems to work. 🙂 |
johnzweng
changed the title
johnzweng
changed the title
core/24.0.1/docker-entrypoint.sh
Outdated
| CONFIG_PREFIX=$'regtest=1\n[regtest]' | ||
| elif [[ "${BITCOIN_NETWORK}" == "testnet" ]]; then | ||
| CONFIG_PREFIX=$'testnet=1\n[test]' | ||
| elif [[ "${BITCOIN_NETWORK}" == "mainnet" ]]; then |
There was a problem hiding this comment.
Starting bitcoind with -mainnet=1 errors with Invalid parameter -mainnet=1. Was this supposed to be signet?
There was a problem hiding this comment.
Specifying it in the config file like this, it gives a warning:
Ignoring unknown configuration value mainnet
There was a problem hiding this comment.
@andrewtoth thanks for your advice! You are totally right. I added the option for signet.
For mainnet I still add [main] to the bitcoin.conf (but don't add mainnet=1 anymore).
…ainnet Signed-off-by: Johannes Zweng <johannes@zweng.at>
|
Hi @NicolasDorier ! 🙂 Just was wondering if this repo is still active, but then discovered the repo under btcpayserver: https://github.com/btcpayserver/dockerfile-deps I assume this is the new place where current Docker image builds live. I will target potential future PRs there. Maybe you could add a notice to this repo which points to the new one. 🙂 |
Dockerfiles based on existing Bitcoin Core version 22.0.
Both images built and tested locally on a x86_64 machine.