Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add single file get #40

Merged
merged 5 commits into from
Nov 16, 2015
Merged

add single file get #40

merged 5 commits into from
Nov 16, 2015

Conversation

EvilDrW
Copy link
Contributor

@EvilDrW EvilDrW commented Nov 5, 2015

No description provided.

EvilDrW and others added 4 commits October 29, 2015 21:43
"get" individual file records
0df605d 
allow for querying for individual uploaded files
pass the result of the query to onGet and to the requestor
fix domain to work like dpd 'get'
18d104a 
other small errors corrected
add chai test for single file record get
15e21c1
test corrections
463748c 
fix typo in single get test
also, adjust behavior of upload (post/put) so that returned text is not
dependent on upload order when uploading multiple files
@EvilDrW EvilDrW mentioned this pull request Nov 5, 2015
Closed
@EvilDrW
Copy link
Contributor Author

EvilDrW commented Nov 5, 2015

i added a test for the new feature, but one of the existing tests (for multiple file upload) always failed. i adjusted the put/post method very slightly so that the old test passed.

@NicolasRitouet
Copy link
Owner

@EvilDrW
To make your test pass, you need to clean the DB first.
I would recommend to upload a file specificaly for your test and run your test on this file.
Something like this:
https://gist.github.com/NicolasRitouet/3c4a777b9cc82a047447
Edit : ping me on gitter if you need more help.

@EvilDrW
Copy link
Contributor Author

EvilDrW commented Nov 16, 2015

I don't understand what you're referring to. When I run npm test in my VM,
it shows all tests pass...

On Mon, Nov 16, 2015, 4:26 AM Nicolas Ritouet notifications@github.com
wrote:

@EvilDrW https://github.com/EvilDrW
To make your test pass, you need to clean the DB first.
I would recommend to upload a file specificaly for your test and run your
test on this file.
Something like this:
https://gist.github.com/NicolasRitouet/3c4a777b9cc82a047447

—
Reply to this email directly or view it on GitHub
#40 (comment)
.

@NicolasRitouet
Copy link
Owner

They don't pass on travis CI:
https://travis-ci.org/NicolasRitouet/dpd-fileupload/jobs/89373025

@EvilDrW
Copy link
Contributor Author

EvilDrW commented Nov 16, 2015

I guess it was an order of operations thing. Adjusted the test so that it passes.

NicolasRitouet added a commit that referenced this pull request Nov 16, 2015
@NicolasRitouet
Merge pull request #40 from EvilDrW/master
be67a72 
add single file get
@NicolasRitouet NicolasRitouet merged commit be67a72 into NicolasRitouet:master Nov 16, 2015
@NicolasRitouet
Copy link
Owner

Thx, merged.
I'll release a new version soon.

@NicolasRitouet
Copy link
Owner

@EvilDrW I just released v0.0.16 with your PR

@EvilDrW EvilDrW mentioned this pull request Nov 17, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvilDrW @NicolasRitouet