Commit index implemented #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else currentState | ||
|
|
||
| -- | Handles `AppendEntriesResponse'. | ||
| handleAppendEntriesResponse :: (Functor m, Monad m) | ||
| handleAppendEntriesResponse :: (Functor m, Monad m, MonadLog m a) |
There was a problem hiding this comment.
I'm most likely missing something obvious, but where is this constraint used?
|
Thanks for going through this. While going through the changes I had one minor question, if you could tell me what I'm missing, this otherwise looks good to me. |
| @@ -54,7 +54,9 @@ handle config state event = case state of | |||
|
|
|||
| -- | Initial state of all nodes. | |||
| initialState :: SomeState | |||
| initialState = wrap FollowerState {_fCurrentTerm = term0, _fVotedFor = Nothing} | |||
| initialState = wrap FollowerState {_fCurrentTerm = term0 | |||
There was a problem hiding this comment.
I think this might be missed from my change, but I think there could be a space before _fCurrentTerm, similarly in later change the } is aligned with the commas...
|
@NicolasT I have made a fix commit if you did not get a notification - please review |
NicolasT
added a commit
that referenced
this pull request
Dec 13, 2013
Implement commit-index propagation
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #7