add a test to match author's tokenization #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I propose to add a test that aims to verify that we are able to reproduce the tokenization produced by the authors of MarkUpLM on the downstream task of WebSRC.
To design this test, I therefore ran the authors' code on the WebSRC downstream task and isolated:
get_xpath_and_treeid4tokens
methodhttps://github.com/microsoft/unilm/blob/e4929f812398207b7fefb4dda6e9debcb8ce34b9/markuplm/examples/fine_tuning/run_websrc/utils.py#L256-L284
convert_examples_to_features
method):https://github.com/microsoft/unilm/blob/e4929f812398207b7fefb4dda6e9debcb8ce34b9/markuplm/examples/fine_tuning/run_websrc/utils.py#L664-L684
This test already reveals some differences:
<s> question </s> content </s>
and we have<s> question </s></s> content
.