Use URI methods to validate URLs instead of patterns #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
uri
1.0.0 (released last November), the defaut parser for theURI
module switched toRFC3986_Parser
(Changelog, PR) and RegExp patterns referenced in Dhalang'sUrlUtils
are missing.This is a proposition to use
URI
methods to validate given URL is an absolute URL. As the programming interface of theURI
module has been mostly stable for very long time now, this method should be more resilient to future code changes.