Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use URI methods to validate URLs instead of patterns #70

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

gael-ian
Copy link
Contributor

Since uri 1.0.0 (released last November), the defaut parser for the URI module switched to RFC3986_Parser (Changelog, PR) and RegExp patterns referenced in Dhalang's UrlUtils are missing.

This is a proposition to use URI methods to validate given URL is an absolute URL. As the programming interface of the URI module has been mostly stable for very long time now, this method should be more resilient to future code changes.

@gael-ian
Copy link
Contributor Author

@NielsSteensma Updates on Gemfile.lock should also fix your publish action on Github Actions so you can release new versions of Dhalang again :)

@NielsSteensma
Copy link
Owner

@NielsSteensma Updates on Gemfile.lock should also fix your publish action on Github Actions so you can release new versions of Dhalang again :)

Yes, sorry for that.

Highly appreciate the contributions!

@NielsSteensma NielsSteensma merged commit fe4967c into NielsSteensma:master Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants