Added net8.0 target and tests (Fixes #94) #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-on-os.yml: Use pipeline artifacts for NuGet and binary artifacts to improve performance
…r specific characters, since some tests depend on them not being defined and need to change for versions of Unicode that define them. Eliminated FEATURE_ICU.
…latile.Read() where supported rather than using a sentinel Comparand that is created using FormatterServices.GetUninitializedObject(), which is now obsolete.
…e Directory.Build.props file
…rialization.EnableUnsafeBinaryFormatterSerialization to true so we can run the binary serialization tests. This has no impact on how binary serialization is handled in production.
…d visibility from the IDE. Binary serialization is disabled by default in .NET 8, so we are preparing users for the eventual removal of these features. They still exist and are fully functional, though.
…itional SDKs will install
…d tests to test our HashSet<T> implementation instead of the one in the .NET runtime
…mentation, for now.
…sts: Fixed tests to use our SortedDictionary<TKey, TValue> implementation instead of the one in the .NET runtime
…ause the new test adapter (the only thing compatible with .NET 8) doesn't seem to support anything lower than net462. Updated test target vs target under test documentation.
…t hasn't changed in .NET 8
… .NET 8 is too slow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94, Fixes #107, Fixes #108
This adds .NET 8 support and tests. This was a lot more work than previous SDK updates because of several issues:
SortedSet<T>andSortedDictionary<T>were updated to match the .NET 8 implementations, while other collections were patched but will still need to be reviewed.net461>net471andnet451>net47because they are no longer supported by the test adapter (which needed upgrading because .NET 8 doesn't support any of the older test adapters).net40(which is now run withnet47) and it takes more than an hour to complete most of the time, which is longer than a job can run on Azure DevOps. So, the script was changed so that .NET 6 is installed instead of .NET 8 when running .NET Framework tests.