J2N.Text.StringFormatter: Added constructor overload for IFormatProvider #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RENTCULTURE and FEATURE_CULTUREINFO_DEFAULTTHREADCURRENTUICULTURE, since they are not supported anyway
…der and deprecated Culture protected property, since it is easily possible to store the CultureInfo reference in a subclass when calling the appropriate constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #44, which targeted the wrong branch.
This adds a constructor overload accepting
IFormatProvidertoStringFormatter. Note that whileStringFormatteris marked as[Serializable], in .NET Core and newer platforms, none of theIFormatProviderimplementations are serializable.Since in Java,
Localeis often used as a field and may be a field of a serializable class, we recommend refactoring the class to accept anIFormatProvideras a method argument rather than using a field, where possible. If that is not possible and serialization is required, it is recommended to create a customIFormatProviderthat wraps the .NET type in order to serialize and deserialize its state. Note that theformatProviderfield inStringFormatterwill automatically be serialized if serialization is supported by the class.This also removes
FEATURE_CULTUREINFO_DEFAULTTHREADCURRENTCULTUREandFEATURE_CULTUREINFO_DEFAULTTHREADCURRENTUICULTURE, as these were not being used, anyway.