Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more extension..js problems | probably constructor.name - nodejs version 4 #387

Closed
noel-schenk opened this issue Sep 19, 2019 · 2 comments
Closed

Comments

@noel-schenk
Copy link
Contributor

noel-schenk commented Sep 19, 2019

Since consolidate.js (used by vue and expressjs) also checks node version 4 this is critical for being compatible with expressjs.

Unhandled rejection SyntaxError: Unexpected token =
    at exports.runInThisContext (vm.js:1:1)
    at Module._compile (module.js:1:1)
    at Object.Module._extensions..js (module.js:1:1)
    at Module.load (/home/noel/Documents/sync/consolidate.js/consolidate.js/node_modules/coffee-script/lib/coffee-script/register.js:1:1)
    at Function.Module._load (module.js:1:1)
    at Module.require (module.js:1:1)
    at require (module.js:1:1)
    at Object.<anonymous> (/home/noel/Documents/sync/consolidate.js/consolidate.js/node_modules/twing/lib/helper/compare.js:4:5)
    at Module._compile (module.js:1:1)
    at Object.Module._extensions..js (module.js:1:1)
    at Module.load (/home/noel/Documents/sync/consolidate.js/consolidate.js/node_modules/coffee-script/lib/coffee-script/register.js:1:1)
    at Function.Module._load (module.js:1:1)
    at Module.require (module.js:1:1)
    at require (module.js:1:1)
    at Object.<anonymous> (/home/noel/Documents/sync/consolidate.js/consolidate.js/node_modules/twing/index.js:1:27)
    at Module._compile (module.js:1:1)
    at Object.Module._extensions..js (module.js:1:1)
    at Module.load (/home/noel/Documents/sync/consolidate.js/consolidate.js/node_modules/coffee-script/lib/coffee-script/register.js:1:1)
    at Function.Module._load (module.js:1:1)
    at Module.require (module.js:1:1)
    at require (module.js:1:1)
    at /home/noel/Documents/sync/consolidate.js/consolidate.js/lib/consolidate.js:1:1
    at /home/noel/Documents/sync/consolidate.js/consolidate.js/lib/consolidate.js:1:1
    at Promise._execute (/home/noel/Documents/sync/consolidate.js/consolidate.js/node_modules/bluebird/js/release/debuggability.js:1:1)
    at Promise._resolveFromExecutor (/home/noel/Documents/sync/consolidate.js/consolidate.js/node_modules/bluebird/js/release/promise.js:1:1)
    at new Promise (/home/noel/Documents/sync/consolidate.js/consolidate.js/node_modules/bluebird/js/release/promise.js:1:1)
    at promisify (/home/noel/Documents/sync/consolidate.js/consolidate.js/lib/consolidate.js:1:1)
    at Function.exports.razor.exports.twing.render (/home/noel/Documents/sync/consolidate.js/consolidate.js/lib/consolidate.js:1:1)
    at /home/noel/Documents/sync/consolidate.js/consolidate.js/lib/consolidate.js:1:1
    at /home/noel/Documents/sync/consolidate.js/consolidate.js/lib/consolidate.js:1:1
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:1:1)

https://github.com/ericmorand/twing/issues/381

I think it would be nice to have travis check this repo as well.

@noel-schenk
Copy link
Contributor Author

Added a workaround to consolidate.js where it excludes tests on versions below 6.0.0 and throws if a user would try using an older version.

tj/consolidate.js#327 (comment)

@ericmorand
Copy link
Member

Thanks for that. I'm not sure how difficult it would be to add node 4 compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants