-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Support for Twing #327
Conversation
Twing starts with node version 6.0.0 so it's excluded from the node tests under 6.0.0. |
Thanks for the PR. I'll review closer this weekend, but for now, I don't think bringing in I'm pretty sure there are some other template engines that don't support older versions of Node.js and are handled in the tests (I'll look into this later). I think doing a simple check in the tests would be sufficient. I'd like to get this library updated to drop older versions of Node.js anyway so it won't be an issue then. |
I think dropping node 4 support should be safe. Don't know what the usage stats are exactly but I'm very enclined to believe that node 4 is barely used anymore. |
Any update on this ? Twing is now in the official list of ExpressJS "out of the box" supported template engines but i believe it depends on this PR being merged ? See https://expressjs.com/en/resources/template-engines.html |
@doowb is there any way we can circumvent the node 4 tests? |
@NoelElias would you move the Since |
@doowb it should be ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NoelElias thanks for the changes, but I meant that we shouldn't use semver
in the "production" code, just in the tests. I made a couple of comments in line. Then I think it will be good to merge.
Thanks! |
Twing is a template engine which supports 100% of the syntax defined by Twig.
https://github.com/ericmorand/twing