-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sensor expiry note on home screen wrap #3499
Sensor expiry note on home screen wrap #3499
Conversation
I think this will break the collector status which is where you see things like Sensor Expired etc. Is the problem actual something to do with the layout_width being 0dp? You can prototype the change by making the android:text field not observable and just replacing with the placeholder text while you debug the layout. |
This isn't changing the collector status. It's only changing how much room on screen is allocated to it. |
I can only speculate that the space is evenly divided between sensor status and sensor expiry since each is given the same weight. I have changed the weight and have given 1% of the shared space to collector status and 99% of the space to sensor expiry. |
So how does it look when both are displayed? |
OK, I now understand. How can I do that so that I can properly test this? |
See my comment 7 mins ago which explains how to prototype that for testing |
Under normal operating conditions, when will both of these two fields be occupied? |
Thanks for the review and catching my error. |
The following images show what the sensor expiry looks like on May 28 and May 29, 2024 releases respectively.
The change of the Android target has affected the behavior of linear layout and caused the sensor expiry note to wrap.
I am sorry I missed this change in my tests of Android 15 upgrade.
This issue has been reported here: #3495
My take is that Android 6 gave no space to an item if it was invisible. But, it seems Android 7 dedicates space to it even if it is invisible.
I am not sure what the purpose of collector status is on the home shelf. This PR gives 99% of the space to sensor expiry and 1% to collector status.
The result is that as long as the collector status is invisible (empty), it will be effectively taking no space and the final result will be as it was before upgrade to Android 15.