Retire old G5 settings #3530
Merged
Retire old G5 settings #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamorham
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
These settings are used by an old old collector which no-one should be using anymore or they will experience many problems. Those settings were experimental when they were produced. You also can remove the findPreference() lookup for these in Preferences.java as well as those are no longer needed either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes 2 settings and the category that only contains the two.
The settings are titled:
Scan constantly
Force Dex to UI thread
Considering we have retired Android 4, 5 and 6, am I wrong to think that no one should need these two settings any longer?
The following image shows what the Debug settings page will look like for G7 after this PR.
It will look exactly the same for a G6 with the addition of the battery options at the bottom also present.