Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US server setting in the Dex share follow menu #3539

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

Navid200
Copy link
Collaborator

This setting is only available in the Dex share upload menu.
But, it is required to be set correctly for a Dex share follower to operate as well.
This PR adds the US server setting to the conditional Dex share follower menu.
The menu before and after this PR is shown below.

Before After
Screenshot_20240614-172942 Screenshot_20240614-173252

@Navid200
Copy link
Collaborator Author

Navid200 commented Jun 14, 2024

This setting already exists.
xDrip as is can be used as a Dex share follower.

The only problem is that for someone who has never used xDrip and is setting it up as a Dex share follower, there is no way to know that they need to go to a different menu to choose the correct setting for the server.
This PR shows the same existing setting also right after the only other two important settings required, user ID and password, in the settings menu as shown above.

Copy link
Collaborator

@jamorham jamorham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible

@jamorham jamorham merged commit 8cc66c1 into NightscoutFoundation:master Jun 25, 2024
1 check passed
@Navid200 Navid200 deleted the Navid_2024_06_14 branch June 25, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants