Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay G6 start prompt by 5 more minutes! #3558

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Jul 5, 2024

We delayed the G6 start prompt until transmitter days were known here: #2757
That change was merged on June 24, 2023.
Since then, we have had 3 stable releases. Yet, there are still reports of G6 sensors not starting on new transmitters and start commands getting stuck in the queue.

As soon as the transmitter days parameter is known, we show the sensor start prompt. When that happens, if you look at the status page, you will still see hunting transmitter for 5 more minutes.

Please let's delay the prompt until hunting transmitter is not shown any longer. That effectively, means 5 more minutes of delay.

@Navid200
Copy link
Collaborator Author

Navid200 commented Jul 5, 2024

What does this effectively change from the user's perspective?

1- After entering the transmitter ID for a G6 transmitter, a red note is shown at the top of the main screen telling you to "verify settings or wait for connectivity". This note is now shown for 5 more minutes before changing to "Now start sensor ...". It could also show indefinitely if there is a transmitter connectivity issue.

2- When you establish connectivity to a G6 transmitter, a "Start Sensor" prompt comes on screen asking you to start. This prompt is shown 5 minutes later than before, or never as long as there is no synch established with the transmitter.

@Navid200
Copy link
Collaborator Author

Navid200 commented Jul 5, 2024

Without this change, we already have a conditional delay on allowing user to start a sensor here:
#2746

But, that seems like a contradiction. If we prompt the user to start, but then tell them they cannot start until there is connectivity, it seems like a bug.

This change will make everything consistent. If we are not going to allow start, we will also not prompt the user to start.
And I hope this will reduce the number of issues due to the start command getting stuck in the queue.
If it doesn't, we will need more aggressive measures like waiting until the battery voltages are known.
I am happy to do that now if it is acceptable to you.

@Navid200 Navid200 marked this pull request as draft July 5, 2024 14:21
@Navid200 Navid200 marked this pull request as ready for review July 5, 2024 14:26
@Navid200 Navid200 changed the title Delay G6 start by 5 more minutes! Delay G6 start prompt by 5 more minutes! Jul 5, 2024
@Navid200
Copy link
Collaborator Author

Navid200 commented Jul 5, 2024

How to verify the UI contradiction

Install the latest Nightly (June 28, 2024) on a test phone after an uninstall. Remove all Dex devices from the list of previously connected devices.

Set up xDrip to connect to a G6 transmitter with no session in progress.
As soon as you approve a pair request, go to the main screen. You will see the start prompt asking you to start.
Screenshot_20240705-104524

Go ahead and start right away. You will see a note that you cannot start a sensor until there is connectivity with the transmitter.
Screenshot_20240705-104540

This will never happen after this PR. After this PR, you will never see the start prompt until a start attempt can proceed.

@Navid200 Navid200 requested a review from jamorham July 13, 2024 19:48
Copy link
Collaborator

@jamorham jamorham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible

@jamorham jamorham merged commit 4464060 into NightscoutFoundation:master Jul 17, 2024
1 check passed
@Navid200 Navid200 deleted the Navid_2024_07_05 branch July 17, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants