Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xDrip Sync master battery level on the follower status page #3803

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Dec 8, 2024

Show master battery level on the follower status page with no need to enable engineering mode:

Before After
Screenshot_20241208-184034 Screenshot_20241208-185109


Please note
This has an unintended ramification:
The battery levels of all followers will also be shown on the status page of the master.
If this is unacceptable, we will need to complicate the code to only show this on the followers but not on the master.
I hope this is not a problem.

Edit:
Fixes: #1848

@Navid200 Navid200 changed the title Sync battery level on status page xDrip Sync master battery level on the follower status page Dec 17, 2024
Copy link
Collaborator

@jamorham jamorham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will likely show all battery status for all master/followers to each other but it any additional clutter is unlikely to be a problem so its okay to move this from behind engineering mode.

@Navid200
Copy link
Collaborator Author

@jamorham Thanks a lor for the review.

Would you please also have a look at these when you can?
#3663
#3707
#3716

@jamorham jamorham merged commit eb6cd64 into NightscoutFoundation:master Dec 17, 2024
1 check passed
@Navid200 Navid200 deleted the Navid_2024_12_08 branch December 17, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to show Master battery level on xDrip+ Sync Followers
2 participants