Decimal separator fix for Edit Alert #3819
Conversation
|
I tested using the alert that I created above with its threshold set to 4.5. It works as expected.
|
Navid200
changed the title
|
I'm not a translation enthusiast with respect to xDrip because I worry that critical matters could get lost in translation. |
|
If this fix is working the same way when in the Bulgarian language, this will be a huge pain relief for many Bulgarian people. Almost all of the Bulgarian people are using the application on Bulgarian. |
|
@lz2jvc If you like, you can test this using the following. But, please note that it is only for testing and should not be shared. It is also not compatible with the official release channels. So, you will not be able to install over an official install. The best course of action is to test on a test phone as opposed to on your main device. https://drive.google.com/file/d/1aolFhU0Tinuk_ZePCyE0ZVEUxZu9hOjd/view?usp=sharing |
I'm currently trying your test implemented version of xDrip+ on a tracking phone. To be honest, it behaves perfectly. There are no bugs with the introduction of (.) and (,) in Cyrillic in the entry of alarm profiles. For the moment, sincere thanks from me for this work. I hope sooner or later it will come out as an official release to stop this pain when entering data in Cyrillic |
|
@lz2jvc Thanks a lot for testing. |
|
@jamorham Would you please review this? |
This is an alternative approach with respect to: #2998
I have used tolerantParseDouble().
In the following table you can see the behaviors before and after.
Please pay attention at the very end to the fractional part, which is dropped before but, is preserved after.