Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

[Suggestion] A couple of suggestions. #1

Closed
nativepapaya opened this issue Oct 18, 2021 · 8 comments
Closed

[Suggestion] A couple of suggestions. #1

nativepapaya opened this issue Oct 18, 2021 · 8 comments

Comments

@nativepapaya
Copy link
Contributor

nativepapaya commented Oct 18, 2021

  1. Dark Knight:
  • Would it be possible to apply the overcap feature to dark knight's single target as well, similar to warrior and gunbreaker? There was only one other plugin that did this but it is no longer updated.
  1. Warrior
  • Changing your 1-2-3 to use Storm's Eye if it is missing is a great idea. The only issue right now is that it seems to only trigger if Storm's Eye is not active, which can lead to situations where it falls of for several GCDs. An alternative would be to check if the duration of Storm's Eye is 15 seconds or less similar to ninja.
  • The warrior overcap feature seems to trigger too early, as it triggers fell cleave as soon as you have 50 rage. A cut off of 70 rage or greater would be better as that would ensure you always have 20 rage available for Uphheaval

Thank you!

@Nik-Potokar
Copy link
Owner

Hey! Thanks for the feedback.

  1. DRK
  • So i went in and added bloodspiller on the main combo now when you are at 80 (Can adjust it later if it feels ood so please let me know) or more gauge after you use souleater.
  1. WAR
  • Tried to add a timer like huton but because Dalamud api doesn't seem to have time detection for warrior buffs im going to look into editing Dalamud and adding that Sorry!!!

But in meantime there is a work around if you just put Storms Eye on hotbar and refresh it manually earlier.
Like this

  • Adjusted the trigger to 70

Thanks!

@nativepapaya
Copy link
Contributor Author

That was quick, thank you!

I did not know that Dalamud did not track the Storm's Eye buff but it makes sense now that I think about it, explains why cooldowns and buff tracking plugins never work for it.

@nativepapaya
Copy link
Contributor Author

I'm back with another Warrior suggestion. This one is minor but I noticed that the overcap feature only checks if the Storm's Eye/Path will overcap. It would work better if the check was also added to Maim as well, as it also adds beast gauge and sometimes you overcap before getting to the Storms.

@Nik-Potokar
Copy link
Owner

Hey im sorry for the very late reply!

I am currently looking into that but having a few issues so it will take a little longer for that.

But in meantime i managed to fix the Storms Eye on main combo (Storms eye will pop instead of storm's path if storms eye buff timer is less than 15sec )

Thanks ^^ hopefully i will fix the maim one soon

Any more suggestions are more than welcome!

@nativepapaya
Copy link
Contributor Author

No worries, don't feel rushed on my behalf.

The storm eye update is awesome, thank you!

@Nik-Potokar
Copy link
Owner

I've managed to update and a little bit of testing and it seems to be working just fine now.

  • Fixed Icon mismatch on fellcleave/innerbeast
  • Added overcap check to Maim

Please let me know if you find any issues or want anything else to be added

You can update it Here
(Il be adding an automated way for addon updates shortly via custom link repo)

@nativepapaya
Copy link
Contributor Author

nativepapaya commented Nov 3, 2021

Tried the the new update and it is awesome. Thank you!

I also noticed the update for Paladin as well, combining Goring Blade and Royal Authority which is neat. It inspired another suggestion though.

Currently with the PLD rotation, is it common to reapply Goring Blade a few second before it expires due to the fact that you want your last GCD when under Fight or Flight to be Goring Blade. This feature would work better if Goring Blade replaced Royal Authority when there is 5 seconds or less on the buff. This ensures that Royal Authority will never be the last hit while under FoF.

I hope this makes sense.

@Nik-Potokar
Copy link
Owner

Hey thanks!

Regarding the PLD i can look into that later tonight.

Thanks for all the suggestions so far <3

Nik-Potokar added a commit that referenced this issue Dec 7, 2021
k-kz added a commit that referenced this issue Apr 16, 2022
k-kz pushed a commit that referenced this issue Oct 6, 2022
Tartarga pushed a commit to Tartarga/XIVSlothCombo that referenced this issue Dec 23, 2022
Taurenkey pushed a commit that referenced this issue Aug 22, 2024
Fix checking for other AST's Helios, and clean up my code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants