Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

[GNB] WickedTalon combo not work #10

Closed
gamer4eg opened this issue Dec 9, 2021 · 4 comments
Closed

[GNB] WickedTalon combo not work #10

gamer4eg opened this issue Dec 9, 2021 · 4 comments

Comments

@gamer4eg
Copy link

gamer4eg commented Dec 9, 2021

oGKD capacities are not used.
(More precisely, they are used incorrectly, only the last oGCD ability in a combo is used)
This works correctly in the base combo plugin. Just take the code from there =)

And another humble question, do you have any plans to combine two GNB combos into one? (Yes, I'm lazy =)

@gamer4eg gamer4eg changed the title [GNB] WickedTalon not work [GNB] WickedTalon combo not work Dec 9, 2021
@Nik-Potokar
Copy link
Owner

Fix will be coming in few hours (after my work)

Oh and yes please if you got a suggestion for a combo do let me know what/how it should work and I will add and try to test as much as I can

(reminder: most of my classes are at 80 so if s feature Is 80+ might need a few updates)

@Nik-Potokar
Copy link
Owner

Meanwhile you can enable the original xivcombo and disable my oGCD feature and enable theirs (both xiv's can be installed at the same time )

@gamer4eg
Copy link
Author

gamer4eg commented Dec 9, 2021

https://github.com/tssailzz8/XIVComboPluginExpandedest/blob/45cdb3177de6bb7b53d4c68e4fdadc0f6a215e1e/XIVComboPlugin/IconReplacer.cs#L900

Look.
This is the most one-button GNB variant I've seen.
But this is an old version of the combo plugin (before EW).
Just take the code from here.

@Nik-Potokar
Copy link
Owner

Fixed now

@gamer4eg gamer4eg closed this as completed Dec 9, 2021
k-kz added a commit that referenced this issue Jun 9, 2022
KOGASA0X pushed a commit to KOGASA0X/XIVSlothCombo that referenced this issue Aug 12, 2022
NebulousByte added a commit to NebulousByte/XIVSlothCombo that referenced this issue Jul 11, 2024
Taurenkey added a commit that referenced this issue Jul 12, 2024
Fix for BRD AoE Combo Feature #10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants