-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the Philips Vereos to the list of scanners #11
Conversation
…ster will vbe dropped.
reconstructed image from another class. These changes had leaked in the master branch in early July.
Are you sure you would like to see all the scanners int he public STIR ? You could hold on to them for now and do this after you have your papers out |
Well, the information needed to characterize the model is rather public: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you make this into a PR for just the Vereos? Then I'll squash merge
@@ -84,7 +84,7 @@ int main(int argc, const char *argv[]) | |||
{ | |||
t.stop(); | |||
std::cout << "Total Wall clock time: " << t.value() << " seconds" << std::endl; | |||
return EXIT_SUCCESS; | |||
return Succeeded::yes; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is incorrect. revert
shared_ptr<TargetT > target_data_sptr(this->get_initial_data_ptr()); | ||
if (this->set_up(target_data_sptr) == Succeeded::no) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no reason for this. It doesn't belong in this PR anyway. Please revert
{ | ||
this->stop_timers(); | ||
return Succeeded::no; | ||
} | ||
|
||
this->stop_timers(); | ||
|
||
return this->reconstruct(this->target_data_sptr); | ||
return this->reconstruct(target_data_sptr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and revert this
@txusser any chance you can finalise this? |
Hi Kris, This project is currently on hold and rather in the hands of Pablo, but I do not expect that they may continue this in the short term unless someone new incorporates into the team. I still collaborate in the SimPET project but not into coding as I moved to a different institution in January. |
sorry to hear that, but do you want to edit this PR a tiny bit such that I can squash-merge it? |
Maybe @NikEfth is more suitable to do this. My knowledge of C is very limited... |
I took these values from NikEfth#11, but cannot check them.
I've added these lines to #59, although disabled, so will close this as no activity. |
No description provided.