Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Philips Vereos to the list of scanners #11

Closed
wants to merge 22 commits into from
Closed

Added the Philips Vereos to the list of scanners #11

wants to merge 22 commits into from

Conversation

txusser
Copy link

@txusser txusser commented Apr 22, 2019

No description provided.

@NikEfth
Copy link
Owner

NikEfth commented Apr 22, 2019

Are you sure you would like to see all the scanners int he public STIR ? You could hold on to them for now and do this after you have your papers out

@txusser
Copy link
Author

txusser commented Apr 23, 2019

Well, the information needed to characterize the model is rather public:
https://philipsproductcontent.blob.core.windows.net/assets/20170523/360753349c5d4a6aa46ba77c015e75b4.pdf
No real point on hiding it. Anyway, no hurry on pulling it now.

Copy link
Collaborator

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you make this into a PR for just the Vereos? Then I'll squash merge

@@ -84,7 +84,7 @@ int main(int argc, const char *argv[])
{
t.stop();
std::cout << "Total Wall clock time: " << t.value() << " seconds" << std::endl;
return EXIT_SUCCESS;
return Succeeded::yes;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is incorrect. revert

Comment on lines +403 to +404
shared_ptr<TargetT > target_data_sptr(this->get_initial_data_ptr());
if (this->set_up(target_data_sptr) == Succeeded::no)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason for this. It doesn't belong in this PR anyway. Please revert

{
this->stop_timers();
return Succeeded::no;
}

this->stop_timers();

return this->reconstruct(this->target_data_sptr);
return this->reconstruct(target_data_sptr);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and revert this

@KrisThielemans
Copy link
Collaborator

@txusser any chance you can finalise this?

@txusser
Copy link
Author

txusser commented Aug 26, 2022

Hi Kris,

This project is currently on hold and rather in the hands of Pablo, but I do not expect that they may continue this in the short term unless someone new incorporates into the team. I still collaborate in the SimPET project but not into coding as I moved to a different institution in January.

@KrisThielemans
Copy link
Collaborator

sorry to hear that, but do you want to edit this PR a tiny bit such that I can squash-merge it?

@txusser
Copy link
Author

txusser commented Sep 7, 2022

Maybe @NikEfth is more suitable to do this. My knowledge of C is very limited...

KrisThielemans added a commit to KrisThielemans/STIR-1 that referenced this pull request Jan 2, 2024
I took these values from NikEfth#11, but cannot check them.
@KrisThielemans
Copy link
Collaborator

I've added these lines to #59, although disabled, so will close this as no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants