Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snowflake module import #61

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Fix snowflake module import #61

merged 3 commits into from
Sep 4, 2024

Conversation

dannymeijer
Copy link
Member

Found some old import references in the snowflake reader and writer modules.

This PR fixes these paths.

How Has This Been Tested?

Added an additional unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dannymeijer dannymeijer requested a review from a team as a code owner September 4, 2024 12:29
maxim-mityutko
maxim-mityutko approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@maxim-mityutko maxim-mityutko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dannymeijer dannymeijer merged commit d993ca9 into main Sep 4, 2024
12 checks passed
@dannymeijer dannymeijer deleted the fix-snowflake-module-import branch September 4, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxim-mityutko maxim-mityutko maxim-mityutko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Koheesio
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannymeijer @maxim-mityutko