Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#54 SMTP authentication #124

Merged
merged 7 commits into from
Jan 24, 2025

Conversation

Jennikon
Copy link
Contributor

@Jennikon Jennikon commented Dec 19, 2024

Description

In some cases SMTP server has authentication, this is not anticipated in a current version of SE library.
Adding possibility to pass through user configuration value that will indicate that smtp authentication is enabled. Password can be passed through user configuration or as secrets with Cerberus or Databricks secrets.

Related Issue

(#54)

Motivation and Context

User opened issue because there is no parameter foreseen to pass the credentials to login to the smtp server. When running the algorithm with the user_config parameter specified (smtp host, port & email address), it fails stating that 'the client is not authenticated to send mail. Not only the mailing fails, but the entire DQ run fails.

How Has This Been Tested?

Tested locally (for password passed in user configuration or with Cerberus stored credentials) and in Databricks notebook(for DBX stored credentials).

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.61%. Comparing base (a80943c) to head (4419bb4).
Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #124      +/-   ##
===========================================
- Coverage   100.00%   99.61%   -0.39%     
===========================================
  Files           22       23       +1     
  Lines         1836     2074     +238     
===========================================
+ Hits          1836     2066     +230     
- Misses           0        8       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jennikon Jennikon marked this pull request as ready for review January 8, 2025 15:58
@asingamaneni
Copy link
Collaborator

@Jennikon thanks for updating the pr, looks like there is a conflict. Can you please resolve it.
Also, from your local can you please run make docs and make sure docs looks good from the visualization standpoint.

@Jennikon
Copy link
Contributor Author

@Jennikon thanks for updating the pr, looks like there is a conflict. Can you please resolve it. Also, from your local can you please run make docs and make sure docs looks good from the visualization standpoint.
@asingamaneni conflicts are resolved, 'make docs' now works locally, I also have changed unworking links to files in spark_expectations/examples to URL links, this way links are working.

Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@asingamaneni asingamaneni merged commit 9e93f15 into Nike-Inc:main Jan 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants