-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#54 SMTP authentication #124
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
===========================================
- Coverage 100.00% 99.61% -0.39%
===========================================
Files 22 23 +1
Lines 1836 2074 +238
===========================================
+ Hits 1836 2066 +230
- Misses 0 8 +8 ☔ View full report in Codecov by Sentry. |
@Jennikon thanks for updating the pr, looks like there is a conflict. Can you please resolve it. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution
Description
In some cases SMTP server has authentication, this is not anticipated in a current version of SE library.
Adding possibility to pass through user configuration value that will indicate that smtp authentication is enabled. Password can be passed through user configuration or as secrets with Cerberus or Databricks secrets.
Related Issue
(#54)
Motivation and Context
User opened issue because there is no parameter foreseen to pass the credentials to login to the smtp server. When running the algorithm with the user_config parameter specified (smtp host, port & email address), it fails stating that 'the client is not authenticated to send mail. Not only the mailing fails, but the entire DQ run fails.
How Has This Been Tested?
Tested locally (for password passed in user configuration or with Cerberus stored credentials) and in Databricks notebook(for DBX stored credentials).
Screenshots (if appropriate):
Types of changes
Checklist: