Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facerecognition: updated deepface.ipynb #721

Merged
merged 18 commits into from
Jun 5, 2024
Merged

Facerecognition: updated deepface.ipynb #721

merged 18 commits into from
Jun 5, 2024

Conversation

Raghucharan16
Copy link

@Raghucharan16 Raghucharan16 commented May 29, 2024

this solves #630 and new version of #645

@invigorzz313
Copy link
Contributor

You need to run all the cells for the proper output.

image

@Raghucharan16
Copy link
Author

Raghucharan16 commented May 30, 2024

@invigorzz313 ofcourse I ran it. And attached the output of every cell in the #645 mentioned pdf. also attaching the same here.
deepface.pdf

@invigorzz313
Copy link
Contributor

invigorzz313 commented May 31, 2024

@invigorzz313 ofcourse I ran it. And attached the output of every cell in the #645 mentioned pdf. also attaching the same here. deepface.pdf

There seems to be an issue then. The PDF you shared has additional cells but your commits in this PR has missing cells after the one in the above shared screenshot.
You can check for yourself in the above 'Files changed' tab.

@Raghucharan16
Copy link
Author

Raghucharan16 commented Jun 1, 2024

@invigorzz313 I've updated the deepface.ipynb file so could please check that once. And anyway I'll update it once again.

@invigorzz313
Copy link
Contributor

@invigorzz313 I've updated the deepface.ipynb file so could please check that once. And anyway I'll update it once again.

Did you push those changes after updating? Because I notice no new changes since last.

@Raghucharan16
Copy link
Author

@invigorzz313 My bad, may be I didn't push the changes I guess now you can check the file.

@Niketkumardheeryan
Copy link
Owner

@Raghucharan16 use matplotlib or any other libraray to show image used in the project and proper comments in your code , add results in your readme.md file.

@Raghucharan16
Copy link
Author

@invigorzz313 notebook and readme has been updated accordingly. check it out once.

@Niketkumardheeryan Niketkumardheeryan added the level2 level2 label Jun 5, 2024
@Niketkumardheeryan Niketkumardheeryan merged commit 5470a44 into Niketkumardheeryan:master Jun 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants