Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jss from 10.5.1 to 10.6.0 in /ui #38

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Mar 16, 2021

Bumps jss from 10.5.1 to 10.6.0.

Release notes

Sourced from jss's releases.

v10.6.0

Improvements

  • [*] Define specific polyfills for specific packages that will be required and define a policy for adding polyfills. Makes sure we will notice if a polyfill is needed in a supported browser by failing the CI. 1456
  • [jss] Use globalThis to support secure version of JavaScript called SES 1449
  • [jss][ts] Styles now supports ClassNames, Props/Data, and Theme as type parameters (eg. Styles<Names, Data, Theme>). 1460
  • [react-jss][ts] withStyles and createUseStyles now support ClassNames, Props, and Theme as type parameters (eg. createUseStyles<Names, Props, Theme>). 1460
  • [react-jss][ts] useStyles finally expects the correct argument type: a Props object with an optional Theme property (both determined from createUseStyles). 1460
  • [react-jss][ts] Support global TS theme definition 1453
  • [react-jss][ts] Allow partial classes prop in withStyles() 1428

Breaking Changes

  • [react-jss][ts] Theme is no longer the first generic type parameter for createUseStyles. 1460
    • There are two main ways to tell TS your Theme's type without reaching over the other type parameters:

Using the function argument.

const useStyles = createUseStyles(theme: Theme => ({
  ruleName: { /* ... */ };
}))

Using the object argument with a function. (You will only need to specify the Theme type once.)

const useStyles = createUseStyles({
  ruleName: ({theme}: {theme: Theme}) => ({
    /* ... */
  })
})
Changelog

Sourced from jss's changelog.

10.6.0 (2021-3-14)

Improvements

  • [*] Define specific polyfills for specific packages that will be required and define a policy for adding polyfills. Makes sure we will notice if a polyfill is needed in a supported browser by failing the CI. 1456
  • [jss] Use globalThis to support secure version of JavaScript called SES 1449
  • [jss][ts] Styles now supports ClassNames, Props/Data, and Theme as type parameters (eg. Styles<Names, Data, Theme>). 1460
  • [react-jss][ts] withStyles and createUseStyles now support ClassNames, Props, and Theme as type parameters (eg. createUseStyles<Names, Props, Theme>). 1460
  • [react-jss][ts] useStyles finally expects the correct argument type: a Props object with an optional Theme property (both determined from createUseStyles). 1460
  • [react-jss][ts] Support global TS theme definition 1453
  • [react-jss][ts] Allow partial classes prop in withStyles() 1428

Breaking Changes

  • [react-jss][ts] Theme is no longer the first generic type parameter for createUseStyles. 1460
    • There are two main ways to tell TS your Theme's type without reaching over the other type parameters:

Using the function argument.

const useStyles = createUseStyles(theme: Theme => ({
  ruleName: { /* ... */ };
}))

Using the object argument with a function. (You will only need to specify the Theme type once.)

const useStyles = createUseStyles({
  ruleName: ({theme}: {theme: Theme}) => ({
    /* ... */
  })
})
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Mar 16, 2021

Dependabot tried to add @dhruv0000 as a reviewer to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/Nikhil-Ladha/meshery/pulls/38/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the Nikhil-Ladha/meshery repository. // See: https://docs.github.com/rest/reference/pulls#request-reviewers-for-a-pull-request

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Mar 16, 2021

The following labels could not be found: kind/chore, pr/dependencies.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Apr 8, 2021

Looks like jss is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Apr 8, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/ui/jss-10.6.0 branch April 8, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants