Implement functions that checks the passed http status code value is in the expected range #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetsuharuohzeki
force-pushed
the
implement-status-check-functions
branch
3 times, most recently
from
4e589c5 to
0e08d21
Compare
Merged
arayaryoma
approved these changes
Jul 25, 2024
…in the expected range This adds functions that checks the passed http status code value is in the expected range for `HttpStatus.***` Names of each of functions are sorted with the spec. They uses `is<Semantics><NumberRange>` convention. - [`HttpStatus.isInformational1xx`](https://httpwg.org/specs/rfc9110.html#status.1xx) - [`HttpStatus.isSuccessful2xx`](https://httpwg.org/specs/rfc9110.html#status.2xx) - [`HttpStatus.isRedirection3xx`](https://httpwg.org/specs/rfc9110.html#status.3xx) - [`HttpStatus.isClientError4xx`](https://httpwg.org/specs/rfc9110.html#status.4xx) - [`HttpStatus.isServerError5xx`](https://httpwg.org/specs/rfc9110.html#status.5xx) We take an approach for unit test that is similar to [property based testing](https://en.wikipedia.org/wiki/Software_testing#Property_testing). The test case input values that satisfies a conditions (For http status code. It's very very simple condition). And all test case files must check input patterns has no problem (no overlap, no missing spans) before running tests in them.
tetsuharuohzeki
force-pushed
the
implement-status-check-functions
branch
from
0e08d21 to
59ae8cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functions that checks the passed http status code value is in the expected range for
HttpStatus.***Names of each of functions are sorted with the spec. They uses
is<Semantics><NumberRange>convention.HttpStatus.isInformational1xxHttpStatus.isSuccessful2xxHttpStatus.isRedirection3xxHttpStatus.isClientError4xxHttpStatus.isServerError5xxTest Strategy
We take an approach that is similar to property based testing.
The test case input values that satisfies a conditions (For http status code. It's very very simple condition).
And all test case files must check input patterns has no problem (no overlap, no missing spans) before running tests in them.
Related Issues
This requires #307