Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an error message when the Swift version isn't correct #115

Closed
DydjyZ opened this issue Aug 25, 2018 · 8 comments
Closed

Show an error message when the Swift version isn't correct #115

DydjyZ opened this issue Aug 25, 2018 · 8 comments

Comments

@DydjyZ
Copy link

DydjyZ commented Aug 25, 2018

Feature Request

Show an error message when the Swift version isn't correct

Feature Description

Hello,

It will be good to show an error when the Swift version isn't 3.X but 4.X, to prevent time wasting for searching the problem :) (Actually there is a silent error and the fingerprint won't show).

Dylan

@NiklasMerz
Copy link
Owner

I mostly run my builds with Xcode on a device or build it for deployment. If you open the project with XCode it will show an error.

@Liam-Ryan
Copy link
Contributor

@NiklasMerz Does this mean that the plugin does not work with cordova-ios 5? ( xcode 10.2.1 required which in turn needs swift 4.0 minimum )

@NiklasMerz
Copy link
Owner

I think the plugin works with Swift 4. Did you try it? I run Xcode 10.2 without any problems.

@Liam-Ryan
Copy link
Contributor

I've tried and we're not getting any response to calling isAvailable(), we are using Swift 5 but I don't think there's any issues between 4 & 5. I'll update to the latest now. You don't have the useswiftversion set to 3.2 still by any chance?

@NiklasMerz
Copy link
Owner

NiklasMerz commented Jul 11, 2019 via email

@Liam-Ryan
Copy link
Contributor

Liam-Ryan commented Jul 11, 2019

The problem is that if we set to swift 3.2 it's not available during the cordova build, we only have 4.0+ since updating to Mojave / Xcode 10.2.1. We can go to Xcode 10.1 or 9 and build with swift 3.2 with no issues but that will not build cordova-ios 5 for us ( 5.0.1 technically ). That's why I was asking for confirmation that the swift 3.2 is required still, it also says that on the npm page

I'll come back once I run the latest plugin, I don't see any obvious errors in xcode when it's set to swift 5. Should I open a new issue in case a pr comes from investigations?

Edit - just to be clear this could be my lack of experience with macos and xcode, I'm much less comfortable with it than windows or linux

@NiklasMerz
Copy link
Owner

NiklasMerz commented Jul 11, 2019 via email

@Liam-Ryan
Copy link
Contributor

Thanks Niklas, I'm sorry for wasting your time on this one I just had to update to the latest version of the plugin and it worked :$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants