-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show an error message when the Swift version isn't correct #115
Comments
I mostly run my builds with Xcode on a device or build it for deployment. If you open the project with XCode it will show an error. |
@NiklasMerz Does this mean that the plugin does not work with cordova-ios 5? ( xcode 10.2.1 required which in turn needs swift 4.0 minimum ) |
I think the plugin works with Swift 4. Did you try it? I run Xcode 10.2 without any problems. |
I've tried and we're not getting any response to calling isAvailable(), we are using Swift 5 but I don't think there's any issues between 4 & 5. I'll update to the latest now. You don't have the useswiftversion set to 3.2 still by any chance? |
Did you set it in your projects config.xml?
Am 11. Juli 2019, 17:10, um 17:10, Liam Ryan <notifications@github.com> schrieb:
…I've tried and we're not getting any response to calling isAvailable(),
we are using Swift 5 but I don't think there's any issues between 4 &
5. I'll update to the latest now. You don't have the useswiftversion
set to 3.2 still by any chance?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#115 (comment)
|
The problem is that if we set to swift 3.2 it's not available during the cordova build, we only have 4.0+ since updating to Mojave / Xcode 10.2.1. We can go to Xcode 10.1 or 9 and build with swift 3.2 with no issues but that will not build cordova-ios 5 for us ( 5.0.1 technically ). That's why I was asking for confirmation that the swift 3.2 is required still, it also says that on the npm page I'll come back once I run the latest plugin, I don't see any obvious errors in xcode when it's set to swift 5. Should I open a new issue in case a pr comes from investigations? Edit - just to be clear this could be my lack of experience with macos and xcode, I'm much less comfortable with it than windows or linux |
No Swift 3.2 is not required. Just try setting the version in config.xml to 5 and see if it builds. We should probably raise the default version anyway.
Am 11. Juli 2019, 17:20, um 17:20, Liam Ryan <notifications@github.com> schrieb:
…The problem is that if we set to swift 3.2 it's not available during
the cordova build, we only have 4.0+ since updating to Mojave / Xcode
10.2.1. We can go to Xcode 10.1 or 9 and build with swift 3.2 with no
issues but that will not build cordova-ios 5 for us ( 5.0.1 technically
). That's why I was asking for confirmation that the swift 3.2 is
required still, it also says that on the npm page
I'll come back once I run the latest plugin, I don't see any obvious
errors in xcode when it's set to swift 5. Should I open a new issue in
case a pr comes from investigations?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#115 (comment)
|
Thanks Niklas, I'm sorry for wasting your time on this one I just had to update to the latest version of the plugin and it worked :$ |
Feature Request
Show an error message when the Swift version isn't correct
Feature Description
Hello,
It will be good to show an error when the Swift version isn't 3.X but 4.X, to prevent time wasting for searching the problem :) (Actually there is a silent error and the fingerprint won't show).
Dylan
The text was updated successfully, but these errors were encountered: