Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle immediately updates mirror cursor #1

Closed
wants to merge 4 commits into from
Closed

Toggle immediately updates mirror cursor #1

wants to merge 4 commits into from

Conversation

xorye
Copy link

@xorye xorye commented Dec 13, 2019

Signed-off-by: David Kwon dakwon@redhat.com

snjeza and others added 3 commits December 10, 2019 14:55
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
@xorye
Copy link
Author

xorye commented Dec 13, 2019

This PR changes onDidChangeTextEditorSelection() to updateCursor().

Now, updateCursor() gets called on vscode.window.onDidChangeTextEditorSelection() and when the toggle config setting is changed.

Under the preference xml.autoSelectingMatchingTags

Fixes redhat-developer#130

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
@xorye
Copy link
Author

xorye commented Dec 13, 2019

I made this new PR instead: redhat-developer#207

@xorye xorye closed this Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants