feat: allow all CORS origins #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CORS policy to allow browser clients from any origin to connect by switching to a wildcard origin and disabling credentials.
- Replace the specific
originswhitelist withallow_origins=["*"] - Change
allow_credentialsfromTruetoFalse - Keep all methods and headers open
Comments suppressed due to low confidence (2)
nilai-api/src/nilai_api/app.py:93
- Allowing all origins can pose a security risk. Consider restricting to trusted domains or making the origins configurable via environment variables.
allow_origins=["*"],
nilai-api/src/nilai_api/app.py:94
- Disabling credentials will prevent sending authentication cookies or session tokens; ensure this aligns with expected client authentication flows or document the change.
allow_credentials=False,
blefo
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows all CORS origin to allow browser client side to connect to nilAI.