fix: added specific mountpoint for api-specific config files #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the host config directory and the AMD SEV device are mounted into the NilAI API containers so that pre-compiled images pick up the latest configuration and can access /dev/sev-guest.
- Adds a bind-mount for the local
src/nilai_api/config/directory into the API service - Repeats the same config mount for the second API replica
- Adds
/dev/sev-guestinto the production compose file
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docker-compose.yml | Mount host config folder into both API service definitions and add SEV device |
| docker-compose.prod.yml | Mount /dev/sev-guest for AMD SEV support in production |
Comments suppressed due to low confidence (3)
docker-compose.yml:131
- Using a relative path for the host config directory can break if docker-compose is run from another working directory. Consider using an absolute path (e.g.,
${PWD}/nilai-api/src/nilai_api/config) to ensure the correct directory is always mounted.
- ./nilai-api/src/nilai_api/config/:/app/nilai-api/src/nilai_api/config/
docker-compose.yml:131
- The container path mixes hyphens and underscores (
/app/nilai-api/src/nilai_api/config/), which may not match the actual filesystem layout. Verify the target path matches the app’s directory structure to avoid missing configs at runtime.
- ./nilai-api/src/nilai_api/config/:/app/nilai-api/src/nilai_api/config/
docker-compose.yml:131
- [nitpick] The
/dev/sev-guestvolume is duplicated across multiple service definitions. Consider extracting this into a shared named volume or using YAML anchors to DRY up the configuration.
- ./nilai-api/src/nilai_api/config/:/app/nilai-api/src/nilai_api/config/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where nilAI may not mount the directory where the config is overwritten on the host when dealing with pre-compiled images. This adds a mountpoint to the default docker-compose to ensure that the latest configs are present. It also adds a /dev/sev-guest mountpoint to the attestation endpoint.