fix: memory-leak-like issue in nv_trust attestation #132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the code to make sure the nv_trust only creates the client once and adds the verifier once. Otherwise, we cause the attester to be attached to a global instance and to be recreated multiple times. This makes the attestation to take exponentially more time, as more verifiers produce the attestation (though one is only produced).
The code is reorganized to ensure the client is only created once.